Fixes Gargoyle thermal vision (Visceratika 2+), refactors sight trait updates #646
+45
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miraviel
changed the title
|
Also the thermal vision seems to remain for quite awhile, I've had it stay active long after the ability ends. |
XanderDox
added
Fix
|
Hello! Your PR has been marked as Feature Freeze as it relates to Species/Splat code. A Maintainer may decide to exempt your PR. Until then, you are encouraged to direct your PR to the ongoing species refactor branch. |
XanderDox
added
Frozen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ties
update_sight()to the gaining/removal of sight-altering traits, rather than individual use-cases callingupdate_sight()whenever they assign or remove these traits (thermal, night vision, x-ray).This fixes the gargoyle thermal vision from Visceratika 2+, it did not work unless something else called
update_sight()on them.Sadly, the signal for adding or removing traits don't handle sources, so I couldn't group these and turn it into a switch case.
Testing:
Activated Visceratika 2, noticed mobs immediately showing up. Waited. Mobs disappeared from sight when it was removed.
Activated Feng Shui 1, noticed I can see mob. Waited. Mob begone.
Activated Auspex 5, re-entered body, saw blue tint + auras for a little more, then they went away.
Why It's Good For The Game
Bugs bad, fixes this report on Discord:
Changelog
fix: Fixes the thermal vision gained from Visceratika 2 and above to immediately work, now it turns on and off as it should.